feature: enable virtual threads, migrate RestTemplate to RestClient, remove stray root properties file - #70
Merged
devin-ai-integration[bot] merged 1 commit intoAug 6, 2026
Conversation
…drop stray root properties file Co-Authored-By: alex.vyshetsky <alex.vyshetsky@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
merged commit Aug 6, 2026
1bc25da
into
devin/1786033413-java21-boot3-base
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime-configuration slice on top of the Java 21 / Spring Boot 3.5 upgrade (#69). Three things, all verified against a running app rather than a compile:
1. Virtual threads actually on. The repo had no classpath
application.propertiesat all — the one at the repo root is not undersrc/main/resources, so Spring never read it. Addedsrc/main/resources/application.propertieswithspring.threads.virtual.enabled=true, and deleted the dead root file (its only content was a commented-out#server.port = 8081, carried over into the real file). The dead file also polluted the/topic/file/operationlisting, which walks the process working directory; that listing is now one entry shorter.Proven with a throwaway
/thread-probeendpoint (removed before commit):2.
RestTemplate→RestClient.RestTemplateis in maintenance mode;RestClientis the modern synchronous client.RestTemplateConfig→RestClientConfig(now building from the auto-configuredRestClient.Builder), and the quote fetch becomes:The important part is that startup resilience does not regress — the upstream quote service
gturnquist-quoters.cfapps.iois dead, and the app must log a WARN and keep going (the bug the base PR just fixed). Verified empirically rather than assumed:RestClientwraps the connection failure inResourceAccessException, which is aRestClientException, so the existing catch clause still applies unchanged. Running the built jar:3. Stream cleanup in
Application.run(...):Arrays.asList(...).stream().map(...).collect(Collectors.toList())→Stream.of(...).<Object[]>map(...).toList(). Safe because the result is only iterated and handed tobatchUpdate, never mutated.Verification
./mvnw clean verifypasses on JDK 21../mvnw spring-boot:runand the built jar; every endpoint curled. JSON shapes unchanged:/→{"id":1,"content":"Hello, World!"},/topic→[{"id":...,"subjectName":...,"subjectDescription":...}]./topicGET/POST/PUT/DELETE,/topic/sort,/topic/minimum/length/{n},/topic/string/operation,/topic/file/operation,/datetimeall behave as before.GET /topic/1(a non-existent id) returns 500 on the base branch too —TopicServicecallsOptional.get()on a missing topic. Not fixed here;service/is outside this slice.No files outside this slice were modified;
pom.xmluntouched.Link to Devin session: https://app.devin.ai/sessions/57144a6d7b48468bbe7d6e587aabf483
Devin Review